Deterministic TagPair assertion of custom registry #1183
Conversation
| // As a sample, check one of the images for E2E and assert their mapping | ||
| var e2eImageTagPair TagPair | ||
| for _, imageTagPair := range imageTagPairs { | ||
| if strings.Contains(imageTagPair.Src, "e2e") { |
There was a problem hiding this comment.
So this ensures the name of the image:tag contains e2e in the string ? Is that always the case ?
There was a problem hiding this comment.
this ensures that what we validate is only the e2e in string, which should scope to gcr.io/kubernetes-e2e-test-images or k8s.gcr.io/e2e-test-images -- both are overridable with custom registry
| } | ||
| } | ||
|
|
||
| if strings.HasPrefix(e2eImageTagPair.Src, customRegistry) { |
There was a problem hiding this comment.
Also, if that loop never break (above) does that create any initializiation hazard for var e2eImageTagPair? It does not seem like it (since e2eimagetagpair is a struct) but check please.
There was a problem hiding this comment.
ah yeah that's a good point. I think e2e will always exist, but I also think it's valuable to have check to assert it.
This ensures that we are testing images which were overriden by custom registry. Some registries are meant to be excluded from override. See #1181 for details. Signed-off-by: Wilson E. Husin <whusin@vmware.com>
Signed-off-by: Wilson E. Husin <whusin@vmware.com>
This ensures that we are testing images which were overriden by custom
registry. Some registries are meant to be excluded from override.
See #1181 for details.
Signed-off-by: Wilson E. Husin whusin@vmware.com
What this PR does / why we need it:
Stabilizes unit tests flake
Which issue(s) this PR fixes
Special notes for your reviewer:
Release note: